Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve assets to project dir #173

Merged
merged 7 commits into from
Jan 25, 2024
Merged

fix: resolve assets to project dir #173

merged 7 commits into from
Jan 25, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Jan 19, 2024

Changes

Fix execution with nextflow run CCBR/CHAMPAGNE and champagne run --main CCBR/CHAMPAGNE.

Issues

NA

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • Update docs if there are any API changes.
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

allow for execution with nextflow run CCBR/CHAMPAGNE
@kelly-sovacool kelly-sovacool self-assigned this Jan 19, 2024
@kelly-sovacool kelly-sovacool added the bug Something isn't working label Jan 19, 2024
@kelly-sovacool
Copy link
Member Author

this actually needs to be ${projectDir} to resolve correctly

@kelly-sovacool kelly-sovacool changed the title fix: resolve assets to working dir fix: resolve assets to project dir Jan 25, 2024
@kelly-sovacool kelly-sovacool added this to the Jan 2024 milestone Jan 25, 2024
@kelly-sovacool kelly-sovacool marked this pull request as ready for review January 25, 2024 17:25
@kelly-sovacool kelly-sovacool merged commit ce70d1f into main Jan 25, 2024
0 of 3 checks passed
@kelly-sovacool kelly-sovacool deleted the projdir branch January 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant