Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2115 Fix Multiple Submit of Create Submission Form #559

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Dec 9, 2024

Overview

This PR attempts to resolve the ability for users to create >1 Data Submissions by rapidly clicking the Create button or pressing enter multiple times quickly.

React hook form already has functionality to prevent multiple concurrent form submissions, but it requires that the submit handler be async.

Note

This change probably shouldn't be merged directly into 3.2.0, since I made some changes to the dialog there, I don't think this is forward-compatible.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-2115

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12242356016

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 54.195%

Totals Coverage Status
Change from base Build 12089903240: 0.004%
Covered Lines: 3761
Relevant Lines: 6448

💛 - Coveralls

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Dec 10, 2024
@amattu2 amattu2 marked this pull request as ready for review December 11, 2024 14:47
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems to work well. Nice job!

@Alejandro-Vega Alejandro-Vega merged commit d65a815 into 3.1.0 Dec 11, 2024
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-2115 branch December 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants