Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: 카카오로그인 응답 형식 수정 (#58) #59

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Refactor: 카카오로그인 응답 형식 수정 (#58) #59

merged 7 commits into from
Nov 7, 2023

Conversation

win-luck
Copy link
Contributor

@win-luck win-luck commented Nov 7, 2023 •
edited
Loading

  • 클라이언트 요청사항을 반영하기 위해, 현재의 HashMap이 아닌 ResponseJwtDto를 도입
  • Jwt토큰 유효성 검사 실패에 대한 Exception 추가 (다만 클라이언트 요청으로 일단은 실패 시 단순 false만 반환)
  • User 객체 프로필사진 속성 Nullable 추가
  • 최초 유저임이 확인될 경우 404가 아닌 id null을 반환하는 것으로 수정
  • 당분간 API 테스트와 관련 로직 수정이 반복될 것이기에, 일시적으로 Jwt 토큰 없이도 모든 API에 접근하는 것을 허용 (최종 제출 시점 전후로 추후 토큰 유효성 검사 통과 여부로 원상복귀시킬 계획)

@win-luck win-luck added the refactor 리팩토링 label Nov 7, 2023
@win-luck win-luck requested a review from synoti21 November 7, 2023 06:28
@win-luck win-luck self-assigned this Nov 7, 2023
@win-luck win-luck linked an issue Nov 7, 2023 that may be closed by this pull request
Refactor: 카카오로그인 응답 형식 수정 (#58) #58
Closed
@win-luck win-luck changed the title Refactor: 카카오로그인 응답데이터 수정 (#58) Refactor: 카카오로그인 응답 형식 수정 (#58) Nov 7, 2023
@win-luck win-luck merged commit a820efa into master Nov 7, 2023
1 check passed
@synoti21 synoti21 deleted the feature/refactor-58-kakaodto branch November 13, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synoti21 synoti21 Awaiting requested review from synoti21

Assignees

@win-luck win-luck

Labels
refactor 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: 카카오로그인 응답 형식 수정 (#58)
1 participant
@win-luck