Refactor: 요청 Dto 검증 과정 추가 (#47) #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
synoti21
reviewed
Nov 2, 2023
| @@ -49,8 +49,8 @@ public ApiResponse<Void> updateFood(UpdateFoodDto updateFoodDto){ | |||
| //음식 삭제 | |||
| @Operation(summary = "[음식] 음식 정보 삭제",description = "음식에 대한 정보를 삭제합니다.") | |||
| @DeleteMapping("/{foodId}/delete") | |||
| public ApiResponse<Void> deleteFood(@PathVariable Long foodId){ | |||
| foodService.deleteFood(foodId); | |||
| public ApiResponse<Void> deleteFood(@PathVariable Long foodId, @RequestHeader Long userId){ | |||
There was a problem hiding this comment.
Redis는 key value쌍으로 캐싱을 하기 때문에 userId에 대한 정보가 받아와야 하죠~
synoti21
reviewed
Nov 2, 2023
| private String token; | ||
|
|
||
| @NotBlank(message = "nickName은 비어있을 수 없습니다.") | ||
| @NotBlank(message = MessageUtil.NOT_BLANK) |
There was a problem hiding this comment.
dto에 validation을 추가함으로써 요청의 무결성을 보장할 수 있을 것 같습니다!
|
유효성 검사 로직을 추가함으로써 좀 더 유효한 요청이 들어올 확률이 높아질 것 같습니다! 수고하셨습니다~ |
synoti21
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation
기타