Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Feat: UserControllerTest 구현 (#28) #30

Merged
merged 4 commits into from
Oct 15, 2023
Merged

✅ Feat: UserControllerTest 구현 (#28) #30

merged 4 commits into from
Oct 15, 2023

Conversation

win-luck
Copy link
Contributor

@win-luck win-luck commented Oct 15, 2023 •
edited
Loading

  • API 응답 객체 직렬화/역직렬화 문제로 내부 구조 변화
  • ApiHeader와 ApiBody 2개가 ApiResponse를 구성하고 있었으나, ApiBody 내부 요소였던 data와 msg를 ApiResponse에 흡수
  • 이를 통해 JSON 직렬화 에러를 해결하여 UserController의 테스트코드를 작성 가능하도록 변경
  • 일부 변수명 및 주석의 오타 및 표현 수정
  • UserServiceTest 예외처리 테스트코드 및 @DisplayName 어노테이션 추가
  • UserControllerTest 작성 (테스트 완료)

Next

  • [한국인 영양소 섭취기준]에 의거하여 개인정보 입력에 따른 기준섭취량 분류 로직 작성
  • 카카오 소셜로그인 구현 (세션관리는 도입은 미정)

@win-luck win-luck added the feat 기능 구현 label Oct 15, 2023
@win-luck win-luck requested a review from synoti21 October 15, 2023 11:50
@win-luck win-luck self-assigned this Oct 15, 2023
@win-luck win-luck linked an issue Oct 15, 2023 that may be closed by this pull request
✅ Feat: UserControllerTest 구현 (#28) #28
Closed
@win-luck win-luck changed the title Feature/28 feat usercontrollertest Feat: UserControllerTest 구현 (#28) Oct 15, 2023
@win-luck win-luck changed the title Feat: UserControllerTest 구현 (#28) ✅ Feat: UserControllerTest 구현 (#28) Oct 15, 2023
synoti21
synoti21 reviewed Oct 15, 2023
View reviewed changes
src/test/java/com/diareat/diareat/controller/UserControllerTest.java
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.when;

@WebMvcTest(controllers = UserController.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ControllerTest코드 작성 까다로우셨을텐데 수고 많으셨어요!

@synoti21
Copy link
Contributor

고생 많으셨습니다!

@synoti21 synoti21 merged commit a0ba351 into master Oct 15, 2023
1 check passed
@synoti21 synoti21 deleted the feature/28-feat-usercontrollertest branch October 15, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synoti21 synoti21 synoti21 left review comments

Assignees

@win-luck win-luck

Labels
feat 기능 구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✅ Feat: UserControllerTest 구현 (#28)
2 participants
@win-luck @synoti21