Fix: 즐찾 해제 시 자식 음식객체 연쇄삭제 명시적으로 추가 (#114) #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
win-luck
commented
Nov 21, 2023
win-luck
commented
- FavoriteFood가 연관관계의 주인이나, FavoriteFood 소멸 시 이를 바라보던 자식 Food 객체가 null을 바라도록 처리되어야 함
- 허나 의도대로 처리되지 않아 직접 setter로 명시적으로 음식들의 즐찾여부를 해제
synoti21
reviewed
Nov 21, 2023
| @@ -128,6 +128,8 @@ public void updateFavoriteFood(UpdateFavoriteFoodDto updateFavoriteFoodDto) { | |||
| @Transactional | |||
| public void deleteFavoriteFood(Long favoriteFoodId, Long userId) { | |||
| validateFavoriteFood(favoriteFoodId, userId); | |||
| FavoriteFood favoriteFood = getFavoriteFoodById(favoriteFoodId); | |||
| favoriteFood.getFoods().forEach(food -> food.setFavoriteFood(null)); // 즐겨찾기 음식으로부터 태어난 음식들의 즐겨찾기 정보를 null로 초기화 | |||
There was a problem hiding this comment.
Cascade가 잘 이루어지지 않는 것 같은데, 일단 이렇게 하되, 나중에 좀 논의를 해봐야 할 것 같습니다.
|
빌드 테스트 실패했는데 확인 부탁드립니다! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.