Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 서버에서의 시간 의존성 제거 #103

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Fix: 서버에서의 시간 의존성 제거 #103

merged 6 commits into from
Nov 16, 2023

Conversation

synoti21
Copy link
Contributor

  • LocalDate.now()로 인해 서버쪽에서 시간 의존성 발생
  • 테스트 코드가 일관된 결과를 도출하지 않음
  • 클라이언트에서 날짜를 parameter로 받고, 이를 통해 LocalDate 객체 생성 방법으로 변경

@synoti21 synoti21 added the fix 버그 및 오류 수정 label Nov 16, 2023
@synoti21 synoti21 self-assigned this Nov 16, 2023
@synoti21 synoti21 linked an issue Nov 16, 2023 that may be closed by this pull request
Fix: 서버 측 시간에서 클라이언트 시간으로 변경 #102
Closed
@synoti21 synoti21 requested a review from win-luck November 16, 2023 14:03
win-luck
win-luck reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@win-luck win-luck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

급하게 로직 수정하신다고 너무 고생 많으셨어요!

@win-luck win-luck merged commit 361426e into master Nov 16, 2023
1 check passed
@synoti21 synoti21 deleted the fix/102-client-localdate branch November 20, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@win-luck win-luck win-luck left review comments

Assignees

@synoti21 synoti21

Labels
fix 버그 및 오류 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: 서버 측 시간에서 클라이언트 시간으로 변경
2 participants
@synoti21 @win-luck