Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused services #248

Closed

Conversation

Arif-Khalid
Copy link
Contributor

Summary:

Fixes part of #72

Type of change:

  • 🎨 Code Refactoring

Changes Made:

  • Removed permission.service.ts
  • Removed data.service.ts

Proposed Commit Message:

Remove unused services in WATcher.

There are a couple of unused services ported from CATcher.

Unnecessary services contributes to code clutter and hurts understandability
of code base.

Let's remove these unused services from WATcher to increase code cleanliness.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

@Arif-Khalid Arif-Khalid changed the title 72 remove unused services Remove unused services Feb 8, 2024
@Arif-Khalid Arif-Khalid self-assigned this Feb 8, 2024
@cheehongw
Copy link
Contributor

Seems like the changes in this PR have already been merged in #238, closing this PR

@cheehongw cheehongw closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants