Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test cases for issue paginator #244

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Refactor test cases for issue paginator #244

merged 1 commit into from
Feb 8, 2024

Conversation

NereusWB922
Copy link
Contributor

Summary:

Fixes part of #85

Type of change:

  • 🧪 Tests Update

Changes Made:

  • Refactor test cases for issue paginator

Proposed Commit Message:

Refactor test cases for issue paginator

The test cases for the issue paginator are outdated. 

Let's refactor the test cases for the issue paginator.

@NereusWB922 NereusWB922 force-pushed the 85-refactor-tests-issue-paginator branch from 4d8d605 to 9199b85 Compare February 7, 2024 10:24
luminousleek
luminousleek approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@luminousleek luminousleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Tiny PRs like these are a lot nicer to review yay. Also, someone should probably rename the createPhaseBugReportingIssue method in the Issue class since that's a carry-over from CATcher

@NereusWB922 NereusWB922 merged commit 339b319 into CATcher-org:main Feb 8, 2024
3 checks passed
@NereusWB922 NereusWB922 deleted the 85-refactor-tests-issue-paginator branch February 8, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luminousleek luminousleek luminousleek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NereusWB922 @luminousleek