Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve activity dashboard design #233

Merged

Conversation

NereusWB922
Copy link
Contributor

@NereusWB922 NereusWB922 commented Jan 30, 2024

Summary:

#232

Type of change:

  • ✨ Enhancement

Changes Made:

  • Hide the id column of activity dashboard
  • Add actor info (avatar and name) to event table
  • Make event table height fix and scrollable
  • Changed event details display (expanded in table -> dialog)

Screenshots:

Current view

image

Scrollable

scrollable

Event details display with dialog

event-details-display

Proposed Commit Message:

Improve activity dashboard design

The ID column in the event table is not useful for the user.

The design of the dashboard is too simple. The event table's height is
not fixed, and the expanded event details might cause the table to be
too long, which is very inconvenient.

To address this, let's hide the ID column, add some information about
the actor, fix the event table height and make it scrollable, and
implement a dialog to display event details.

@damithc
Copy link
Contributor

damithc commented Jan 30, 2024

@NereusWB922 Noticed in passing that the proposed commit message body is not wrapped to the appropriate width.

@NereusWB922
Copy link
Contributor Author

@NereusWB922 Noticed in passing that the proposed commit message body is not wrapped to the appropriate width.

Updated the commit message. Thank you.

@chunweii chunweii requested a review from gycgabriel February 6, 2024 06:24
Copy link
Collaborator

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I understand this is the starting stages of this dashboard so it's alright, but let's strive to keep future PR sizes smaller
(~100 LoC)

@gycgabriel gycgabriel merged commit 5528680 into CATcher-org:main Feb 6, 2024
3 checks passed
@NereusWB922 NereusWB922 deleted the 232-improve-activity-dashboard-design branch February 6, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants