Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated tests #85

Closed
15 tasks done
cheehongw opened this issue Feb 19, 2023 · 3 comments
Closed
15 tasks done

Remove outdated tests #85

cheehongw opened this issue Feb 19, 2023 · 3 comments
Assignees
Labels
aspect-Testing category.Chore a task that needs to be done p.Medium to be done when there are no other higher priority issues

Comments

@cheehongw
Copy link
Contributor

cheehongw commented Feb 19, 2023

There are many failing unit tests in WATcher. These tests are inherited from CATcher and require updating.

Reasons for failure fall under these 2 categories:

  1. unit under test has been removed when changing from WATcher to CATcher
  2. unit under test has undergone changes since CATcher

It should be relatively safe to fix category 1 since we are removing tests for files that don't exist anymore.

Fixes for category 2 should be done carefully, and should try to preserve tests cases as much as possible

To refactor test:

  • Login Component
  • Session Model
  • Issue Paginator
  • Issue Sorter
  • Github Label constants
  • Search Filter
  • Issue Model
  • Label Service
  • Label Filter Bar Component
  • Phase Service
  • User Service

To remove test:

  • markdown.css (in test env stylesheet)
  • Conflict Model
  • Permissions service
  • Unused constants
@chunweii
Copy link
Contributor

Issue is related to #72

@chunweii chunweii added the p.Medium to be done when there are no other higher priority issues label Apr 13, 2023
@chunweii
Copy link
Contributor

@Eclipse-Dominator Are you working on this issue? If not you can unassign yourself and let others work on this

@NereusWB922
Copy link
Contributor

Hi, since the outdated tests have been refactored and the pre-push hook for npm run test is also enabled, I think we can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect-Testing category.Chore a task that needs to be done p.Medium to be done when there are no other higher priority issues
Projects
None yet
4 participants