Skip to content

Commit

Permalink
Refactor milestone filters (#264)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Arif-Khalid
Arif-Khalid authored Feb 28, 2024
1 parent ad94663 commit ac150e0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/app/shared/filter-bar/filter-bar.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
<mat-label>Milestone</mat-label>
<mat-select
#milestoneSelectorRef
[(value)]="this.dropdownFilter.milestones"
(selectionChange)="applyDropdownFilter()"
[value]="this.dropdownFilter.milestones"
(selectionChange)="this.filtersService.updateFilters({ milestones: $event.value })"
[disabled]="this.milestoneService.hasNoMilestones"
multiple
>
Expand Down

1 comment on commit ac150e0

@Arif-Khalid
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Milestone filters are handled in filter-bar.component.ts

This filter is handled outside the filters service

Let's refactor the milestone filters to use the filters service

Please sign in to comment.