Skip to content

Commit

Permalink
[#72] Remove package ngx-markdown (#145)
Browse files Browse the repository at this point in the history
ngx-markdown is a markdown formatter/parser that was ported over from
CATcher. As WATcher does not use any form of markdown parser, this
package currently does not serve any use in WATcher.

Therefore, let's remove the unused package and the related components.
  • Loading branch information
Eclipse-Dominator authored Jul 14, 2023
1 parent ecaf031 commit 95e36a6
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 755 deletions.
14 changes: 2 additions & 12 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,8 @@
"src/favicon.256x256.png",
"src/favicon.512x512.png"
],
"styles": [
"node_modules/prismjs/themes/prism-okaidia.css",
"src/styles.css",
"src/markdown.css",
"./node_modules/@angular/material/prebuilt-themes/indigo-pink.css"
],
"scripts": [
"node_modules/marked/lib/marked.js",
"node_modules/prismjs/prism.js",
"node_modules/prismjs/components/prism-csharp.min.js",
"node_modules/prismjs/components/prism-css.min.js"
]
"styles": ["src/styles.css", "./node_modules/@angular/material/prebuilt-themes/indigo-pink.css"],
"scripts": []
},
"configurations": {
"staging": {
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"graphql-tag": "2.11.0",
"karma-spec-reporter": "0.0.32",
"moment": "^2.24.0",
"ngx-markdown": "^10.1.1",
"ngx-mat-select-search": "^3.3.3",
"node-fetch": "^2.6.9",
"rxjs": "6.5.5",
Expand Down
8 changes: 0 additions & 8 deletions src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { HttpLink, HttpLinkModule } from 'apollo-angular-link-http';
import { InMemoryCache, IntrospectionFragmentMatcher } from 'apollo-cache-inmemory';
import { ApolloLink } from 'apollo-link';
import { setContext } from 'apollo-link-context';
import { MarkdownModule, MarkedOptions } from 'ngx-markdown';
import 'reflect-metadata';
import graphqlTypes from '../../graphql/graphql-types';
import '../polyfills';
Expand All @@ -32,7 +31,6 @@ import { UserService } from './core/services/user.service';
import { IssuesViewerModule } from './issues-viewer/issues-viewer.module';
import { LabelDefinitionPopupComponent } from './shared/label-definition-popup/label-definition-popup.component';
import { HeaderComponent } from './shared/layout';
import { markedOptionsFactory } from './shared/lib/marked';
import { RepoChangeFormComponent } from './shared/repo-change-form/repo-change-form.component';
import { SharedModule } from './shared/shared.module';

Expand All @@ -53,12 +51,6 @@ import { SharedModule } from './shared/shared.module';
ActivityDashboardModule,
SharedModule,
HttpClientModule,
MarkdownModule.forRoot({
markedOptions: {
provide: MarkedOptions,
useFactory: markedOptionsFactory
}
}),
AppRoutingModule,
ApolloModule,
HttpLinkModule
Expand Down
3 changes: 1 addition & 2 deletions src/app/issues-viewer/issues-viewer.module.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { NgModule } from '@angular/core';
import { MarkdownModule } from 'ngx-markdown';
import { FilterBarModule } from '../shared/filter-bar/filter-bar.module';
import { IssuesPrCardModule } from '../shared/issue-pr-card/issue-pr-card.module';
import { SharedModule } from '../shared/shared.module';
Expand All @@ -8,7 +7,7 @@ import { IssuesViewerRoutingModule } from './issues-viewer-routing.module';
import { IssuesViewerComponent } from './issues-viewer.component';

@NgModule({
imports: [FilterBarModule, IssuesViewerRoutingModule, IssuesPrCardModule, SharedModule, MarkdownModule.forChild()],
imports: [FilterBarModule, IssuesViewerRoutingModule, IssuesPrCardModule, SharedModule],
declarations: [IssuesViewerComponent, CardViewComponent],
exports: [IssuesViewerComponent, CardViewComponent]
})
Expand Down
20 changes: 0 additions & 20 deletions src/app/shared/lib/marked.ts

This file was deleted.

Loading

0 comments on commit 95e36a6

Please sign in to comment.