-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add login redirect #1256
Add login redirect #1256
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
- Coverage 54.82% 54.62% -0.21%
==========================================
Files 105 105
Lines 2858 2867 +9
Branches 503 504 +1
==========================================
- Hits 1567 1566 -1
- Misses 1030 1038 +8
- Partials 261 263 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean and effective method of storing and using the original URL. Let's wait for senior review before merging but LGTM!
Cool, is it possible to have an error popup when this happens? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary:
Fixes #1229
Changes Made:
Unlike CATcher-org/WATcher#255,
Note that it only redirects to the current phase. If there are multiple open phases, the app only allows redirection to the "current phase", which is the first available phase. However, given that in CATcher, only one phase is allowed at a time,
Proposed Commit Message: