Migrate from TSLint to ESLint #1250

MadLamprey · 2024-02-21T09:21:05Z

Summary:

Changes Made:

Migrate to ESLint from TSLint
- See: https://github.com/angular-eslint/angular-eslint/blob/main/docs/MIGRATING_FROM_TSLINT.md
- All changes mentioned have been reviewed
- Each rule mentioned in `tslint.json` has been reviewed and its ESLint counterpart has been defined in `.eslintrc.json`.
- There are a few rules that have not been mapped due to huge changes to the codebase or errors produced as a result of the translation. These include:
  - `deprecation/depreciation`
  - `prefer-const`
  - `dot-notation`
  - `import-spacing`
- Few changes have been made to prevent errors that were not earlier raised with the TSLint configuration

Proposed Commit Message:

Migrate to ESLint

TSLint is now deprecated in favour of ESLint. We should keep our dependencies up-to-date.

Let's migrate to ESLint to ensure that our linter is up-to-date.

codecov-commenter · 2024-02-21T09:24:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (e319865) to head (44dc8eb).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
+ Coverage   54.84%   58.27%   +3.43%     
==========================================
  Files         105      105              
  Lines        2859     2598     -261     
  Branches      503      291     -212     
==========================================
- Hits         1568     1514      -54     
- Misses       1030     1033       +3     
+ Partials      261       51     -210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cheehongw

I tried this PR and it didn't catch some of the lint mistakes that I introduced. For exampl,e, i tried importing some unused components in a file, and the old linter caught it while the new linter passed all the files.

Perhaps it failed to convert the lint rules in tslint.json to those in .eslintrc.json?

…247-upgradeTSLint

cheehongw

i feel not all the lint changes are for the best. for example the changes in app-routing.module.ts makes it harder to read.

Also another personal preference would be to not change code en masse for the sake of styling as it makes it harder to trace code changes.

please revert the changes in the repository, then check the arrow-body-style rule again

cheehongw · 2024-04-10T10:05:28Z

.eslintrc.json

+            "type": "attribute"
+          }
+        ],
+        "arrow-body-style": ["error", "always"],


try changing this to as-needed

https://eslint.org/docs/latest/rules/arrow-body-style#as-needed

This reverts commit d7c506b.

This reverts commit 16cd3f2.

…Tcher into 1247-upgradeTSLint

cheehongw · 2024-04-18T02:54:53Z

src/app/app.module.ts

-      return { headers: { Authorization: `Token ${this.authService.accessToken.getValue()}` } };
-    });
+    const basic = setContext(() => ({ headers: { Accept: 'charset=utf-8' } }));
+    const auth = setContext(() => ({ headers: { Authorization: `Token ${this.authService.accessToken.getValue()}` } }));


ok i think these changes are good for readability

The following comment blocks are valid: /**************** * Comment block ****************/ /**************** * Comment block */

I cannot identify the issue. It is failing on github ci but not locally. On Github CI, it is identifying lint errors where it shouldnt be as well.

cheehongw · 2024-04-26T09:31:18Z

For some unknown reason, the arrow-body-style keeps failing CI at 2 specific lines even though it passes linting locally.

One of the instances is below, in issue.service.ts. The first function body passes the lint check on github CI, but the one on the bottom doesn't, even though they are exactly the same.

cheehongw

I will merge this PR without the arrow-body-style rule for now.

I don't think it is worth the effort to figure out why it doesn't work for eslint v7 when official documentation only exists for eslint v8 and v9. We should revisit this when eslint is upgraded to its latest version.

Misra Aditya added 2 commits February 21, 2024 16:00

Install ESLint and dependencies

16cd3f2

Migrate TSLint to ESLint

901e500

cheehongw requested changes Mar 3, 2024

View reviewed changes

cheehongw mentioned this pull request Mar 4, 2024

Upgrade to Angular 13 #1249

Merged

Misra Aditya added 12 commits March 4, 2024 13:40

Update ESLint config to match TSLint rules

d7c506b

Fix linting errors

fd86c47

Fix linting errors

12ad118

Update ESLint config

136b8ca

Fix linting errors

af1b369

Fix linting errors

ae82cf4

Fix linting errors

890c0d2

Fix linting errors

b7b2b49

Merge branch 'master' of https://github.com/MadLamprey/CATcher into 1…

03b9c95

…247-upgradeTSLint

Fix linting errors

f7ad387

Fix linting errors

8fe6be4

Update ESLint configuration

53b282f

MadLamprey requested a review from cheehongw March 18, 2024 05:51

cheehongw requested changes Apr 10, 2024

View reviewed changes

Misra Aditya added 7 commits April 12, 2024 18:03

Revert "Update ESLint config to match TSLint rules"

0e31e99

This reverts commit d7c506b.

Revert "Install ESLint and dependencies"

3ed49f0

This reverts commit 16cd3f2.

Revert "Install ESLint and dependencies"

3ce7747

This reverts commit 16cd3f2.

Update config

5168a31

Fix bugs

64137d8

Fix bugs

ba60c1f

Fix bugs

ed8e3da

MadLamprey force-pushed the 1247-upgradeTSLint branch from 53b282f to ed8e3da Compare April 12, 2024 10:55

Misra Aditya added 3 commits April 15, 2024 13:04

Merge branch '1247-upgradeTSLint' of https://github.com/MadLamprey/CA…

76b194b

…Tcher into 1247-upgradeTSLint

Fix bugs

3b10b0d

Fix error

c6ec6a1

Misra Aditya added 3 commits April 15, 2024 13:31

Fix errors

97eaf0e

Fix errors

fcbe5d8

Fix bugs

3c5044d

cheehongw reviewed Apr 18, 2024

View reviewed changes

cheehongw self-requested a review April 18, 2024 03:14

cheehongw added 8 commits April 26, 2024 15:07

revert almost all new style changes

34b59c2

relax arrow-body-style rule for objects

3c9d99f

Relax rule to allow comment blocks made with *

44dc8eb

The following comment blocks are valid: /**************** * Comment block ****************/ /**************** * Comment block */

Apply exceptions

b276b0c

fix lint - no-inferrable-types

afffb21

Use return for object literals

e7cbfb8

Disable max-len lint rule for this file

834c920

Fix redundant returns (lint: arrow-body-style)

a243ae7

cheehongw force-pushed the 1247-upgradeTSLint branch from 5deb705 to a243ae7 Compare April 26, 2024 08:59

Remove arrow-body-style rule

b096193

I cannot identify the issue. It is failing on github ci but not locally. On Github CI, it is identifying lint errors where it shouldnt be as well.

Merge branch 'master' into 1247-upgradeTSLint

d026173

cheehongw approved these changes Apr 26, 2024

View reviewed changes

cheehongw merged commit 5a91541 into CATcher-org:master Apr 26, 2024
3 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate from TSLint to ESLint #1250

Migrate from TSLint to ESLint #1250

MadLamprey commented Feb 21, 2024 •

edited

Loading

codecov-commenter commented Feb 21, 2024 •

edited

Loading

cheehongw left a comment

cheehongw left a comment •

edited

Loading

cheehongw Apr 10, 2024

cheehongw Apr 18, 2024

cheehongw commented Apr 26, 2024

cheehongw left a comment

Migrate from TSLint to ESLint #1250

Migrate from TSLint to ESLint #1250

Conversation

MadLamprey commented Feb 21, 2024 • edited Loading

Summary:

Changes Made:

Proposed Commit Message:

codecov-commenter commented Feb 21, 2024 • edited Loading

Codecov Report

cheehongw left a comment

Choose a reason for hiding this comment

cheehongw left a comment • edited Loading

Choose a reason for hiding this comment

cheehongw Apr 10, 2024

Choose a reason for hiding this comment

cheehongw Apr 18, 2024

Choose a reason for hiding this comment

cheehongw commented Apr 26, 2024

cheehongw left a comment

Choose a reason for hiding this comment

MadLamprey commented Feb 21, 2024 •

edited

Loading

codecov-commenter commented Feb 21, 2024 •

edited

Loading

cheehongw left a comment •

edited

Loading