Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for version 3.5.1 #1218

Merged
merged 3 commits into from
Oct 26, 2023
Merged

New release for version 3.5.1 #1218

merged 3 commits into from
Oct 26, 2023

Conversation

vigneshsankariyer1234567890
Copy link
Contributor

Summary:

New release

Proposed Commit Message:

Merge master into release to release V3.5.1

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f07a240) 53.93% compared to head (7ebb845) 53.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1218      +/-   ##
===========================================
- Coverage    53.93%   53.89%   -0.05%     
===========================================
  Files          101      101              
  Lines         2881     2885       +4     
  Branches       534      534              
===========================================
+ Hits          1554     1555       +1     
- Misses         984      988       +4     
+ Partials       343      342       -1     
Files Coverage Δ
src/app/core/services/github.service.ts 15.17% <0.00%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Use rest api first, then raw githubusercontent

REST API should be more reliable, but it has a rate limit
for unauthenticated requests. Let's use REST API call for
the fetching of settings.json, with a failsafe being
raw.githubusercontent.com.
@chunweii chunweii merged commit 7ebb845 into release Oct 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants