Skip to content

Commit

Permalink
Update CATcher to V3.4.4 (#1020)
Browse files Browse the repository at this point in the history
* Fixes #1014 Tester responses: All bugs are marked as 'Faulty Issues'

* Update CATcher to version V3.4.4

Co-authored-by: chunweii <[email protected]>
  • Loading branch information
luminousleek and chunweii authored Oct 17, 2022
1 parent 4ef3064 commit d8c7240
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "CATcher",
"version": "3.4.3",
"version": "3.4.4",
"main": "main.js",
"scripts": {
"postinstall": "npm run postinstall:electron && electron-builder install-app-deps",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { buildTeamResponseSectionParser } from './section-parsers/common-parsers
import { TesterResponseSectionParser } from './section-parsers/tester-response-section-parser.model';
import { Template } from './template.model';

const { coroutine, many1, str, whitespace } = require('arcsecond');
const { coroutine, many1, str, optionalWhitespace, possibly, whitespace } = require('arcsecond');

interface TesterResponseParseResult {
teamResponse: string;
Expand All @@ -15,12 +15,17 @@ interface TesterResponseParseResult {
teamChosenType: string;
}

const GITHUB_UI_EDIT_WARNING =
'[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]';
const TESTER_RESPONSES_HEADER = '# Items for the Tester to Verify';
const DISAGREE_CHECKBOX_DESCRIPTION = 'I disagree';

const TeamResponseSectionParser = buildTeamResponseSectionParser(TESTER_RESPONSES_HEADER);

export const TesterResponseParser = coroutine(function* () {
yield possibly(str(GITHUB_UI_EDIT_WARNING));
yield optionalWhitespace;

const teamResponse = yield TeamResponseSectionParser;

// parse tester responses from comment
Expand Down
1 change: 1 addition & 0 deletions tests/constants/githubcomment.constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const EMPTY_TEAM_RESPONSE: GithubComment = {
// Type and severity disagreeement
export const TEAM_RESPONSE_MULTIPLE_DISAGREEMENT = {
body:
'[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]\n\n' +
"# Team's Response\n" +
'This is a dummy team response comment: ' +
'Thanks for the feedback\n\n' +
Expand Down

0 comments on commit d8c7240

Please sign in to comment.