Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fusion model patch for 2.0.1rc4 #366

Open
wants to merge 9 commits into
base: 2.0.1rc4
Choose a base branch
from
Open

Fusion model patch for 2.0.1rc4 #366

wants to merge 9 commits into from
+575 −171

Conversation

celikbasak
Copy link
Member

@celikbasak celikbasak commented Nov 15, 2024 •
edited
Loading

Overview

Offline analysis workflow change, fusion model training-testing added, bugfix in gaze reshaper & gaze model.

Ticket

Contributions

  • Offline analysis workflow updated to include train-test split for fusion analysis if there are multiple active devices.
  • Fusion.py added for generating model performance measures.
  • Bugfix in GazeReshaper where all NaN values are removed. Further tests addded.
  • Unused gaze models removed. Gaze model name updates.
  • All models are updated in accordance with scikit-learn estimators.

Test

  • Unit tests to be implemented.

Documentation

  • Model documentation will be updated.

Changelog

  • CHANGELOG.md updated.

@tab-cmd tab-cmd requested a review from lawhead November 15, 2024 18:48
tab-cmd
tab-cmd requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor changes and questions. Thanks again for getting this through!

bcipy/signal/model/evaluate/fusion.py Outdated Show resolved Hide resolved
bcipy/signal/model/evaluate/fusion.py Outdated Show resolved Hide resolved
bcipy/signal/model/evaluate/fusion.py Outdated Show resolved Hide resolved
bcipy/signal/model/evaluate/fusion.py Outdated Show resolved Hide resolved
bcipy/signal/model/evaluate/fusion.py Show resolved Hide resolved
bcipy/signal/model/evaluate/fusion.py Outdated Show resolved Hide resolved
bcipy/signal/model/offline_analysis.py Outdated Show resolved Hide resolved
bcipy/signal/model/offline_analysis.py Show resolved Hide resolved
bcipy/signal/model/offline_analysis.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@tab-cmd tab-cmd self-requested a review November 24, 2024 23:53
@celikbasak
Copy link
Member Author

Thank you so much for your updates/bug fixes Tab!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd tab-cmd requested changes

@lawhead lawhead Awaiting requested review from lawhead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@celikbasak @lawhead @tab-cmd