Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params Form fixes #364

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Params Form fixes #364

merged 3 commits into from
Nov 13, 2024

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Nov 8, 2024

Overview

  • Fixed issue with scroll wheel on numeric inputs
  • Created a console script for bcipy-params

Ticket

https://www.pivotaltracker.com/story/show/188529406

@lawhead lawhead requested a review from tab-cmd November 8, 2024 22:40
@lawhead lawhead changed the base branch from main to 2.0.1rc4 November 8, 2024 22:41
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -316,7 +316,7 @@ def edit_parameters(self) -> None:
return None

output = subprocess.check_output(
f'python {BCIPY_ROOT}/gui/parameters/params_form.py -p {self.parameter_location}',
f'python {BCIPY_ROOT}/gui/parameters/params_form.py -p "{self.parameter_location}"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use your new command here!

@lawhead lawhead merged commit d91a878 into 2.0.1rc4 Nov 13, 2024
9 checks passed
@lawhead lawhead deleted the params-form-spaces branch November 13, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants