Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry Preview Button Evidence Bug #359

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Nov 1, 2024

Overview

Ensure that button press evidence in Copy Phrase tasks is only produced when presses are meaningful (not in preview-only mode).

Ticket

https://www.pivotaltracker.com/story/show/188514964

Contributions

  • Added unit tests to replicate the bug
  • Implemented a fix

@lawhead lawhead requested a review from tab-cmd November 1, 2024 23:46
@lawhead lawhead merged commit 171c706 into 2.0.0rc4 Nov 2, 2024
9 checks passed
@lawhead lawhead deleted the conditional-btn-evidence branch November 2, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants