Simulator fix and orchestrator saving updates #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help with data packaging and debugging
Update CHANGELOG
lawhead
approved these changes
Oct 29, 2024
bcipy/simulator/task/copy_phrase.py
Outdated
|
|
||
| # Check if the evidence type is supported | ||
| if evidence_type not in SUPPORTED_EVIDENCE_TYPES: | ||
| raise ValueError(f"Unsupported evidence type: {evidence_type}. Supported types: {SUPPORTED_EVIDENCE_TYPES}") |
There was a problem hiding this comment.
I would prefer that the task doesn't make the call as to what evidence is supported. When we add the Gaze support we shouldn't need to change anything in the task. Maybe just try to create the EvidenceType from the string and let that fail if it's not valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the simulator to support the new Task refactor and updates the parameter name and data save path in the orchestrator. Some cleanup of variable names, data in Tasks, and typing are included.
Ticket
Contributions
DEFAULT_PARAMETER_FILENAMEtoDEFAULT_PARAMATERS_FILENAMEfor consistency.get_evidence_typein the simulator to check for supported types and cast to an ENUM (from a string). Ensure it is used wherever needed.DEFAULT_PARAMATERS_FILENAMEto support use throughout the codebase.user/experiment/datetime/tasks/touser/date/experiment/timestamp/tasks/Test
make test-allbcipy-sim -d ".../2024-10-17_13-33-26" -m ".../Matrix Calibration_2024-10-17_13-00-19" -g "*Copy*" -p ".../parameters.json" -n "25"bcipy --fake --task "RSVP Calibration"-nvbcipy --fake --task "RSVP Calibration"bcipy --fake --task "Matrix Calibration"-nvbcipy --fake --task "Matrix Copy Phrase"-nvDocumentation
CHANGELOG
Updated with all current 2.0rc4 changes of note.