Report artifact enhancements, README, Python 3.10.6 support #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: verify with user data in field
tab-cmd
changed the title
lawhead
approved these changes
Oct 26, 2024
| @@ -15,7 +15,7 @@ class FileDialog(QWidget): | |||
|
|
|||
| def __init__(self): | |||
| super().__init__() | |||
| self.title = 'PyQt6 file dialogs - pythonspot.com' | |||
There was a problem hiding this comment.
Good catch. Looks like that was left over from a copy-paste.
| PEAK_THRESHOLD = 75e-7 | ||
| PEAK_MIN_DURATION = 0.005 | ||
| PEAK_THRESHOLD = 15e-6 | ||
| PEAK_MIN_DURATION = 0.001 |
There was a problem hiding this comment.
It might be useful to have a comment or documentation somewhere about how these values were determined.
There was a problem hiding this comment.
I will add a comment; before we release 2.0, I am proposing a few enhancements to this module that should help with configuration and use. https://www.pivotaltracker.com/story/show/188483451
lawhead
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After meeting with the neurophysiology and clinical team, several changes were needed to support the new BciPy report. This fixes some errors found, sets new defaults, adds a demo, and cleans up some of the documentation. Upgrades MNE.
Ticket
(https://www.pivotaltracker.com/story/show/188110245)
Contributions
demo_calibration_report.py: A demo to show how to run the action and allow the report to be generated offline in case of failures in the fieldbcipy/helpers/stimuli.py: fix baseline designationbcipy/helpers/convert.py: change the default to mV (most common).bcipy/gui/file_dialog.py: allow for prompt in loading of directoriesbcipy/signal/evaluate/artifact.py: WIP, change defaults, add more loggingbcipy/task/actions.py: Update the BciPyCalibrationReport to prompt for the protocol directory if not provided. Pass the correct labels to visualize_erp. Add some logging.setup.py: to include python 3.10.6. Note this breaks editable installs and some console scripting. However, much of the library would still work as a package. This is expected, even if undesired see 1 and 2. A ticket was created to refactor our builds to support future versions of python here. When upgrading to 3.11, we may have to lose support for 3.8. However, other dependencies can then be upgraded (mne, etc.).Test
make test-allDocumentation
Changelog