Rust code splitting #36
Conversation
dzervas
force-pushed
the
sketch-features-rework
branch
2 times, most recently
from
3363029 to
5303d0e
Compare
|
Hey this looks pretty good but could you explain a bit more thoroughly your thought process? Please provide a few sentences of description that helps us understand what you did, why, and an explanation of any choices you made along the way like choosing which dependencies to add. |
|
As I started reading the code, almost all the code was in project.rs, about 1800 lines and I started splitting it roughly in a struct-per-file manner (quite standard for rust code). I also "folded" some tests (instead of copy-paste code, have an array and iterate over it) That was the main PR but last night I started hunting for unwraps and error bubbling (I know that we don't need it right now but it can help a ton during dev). |
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
…iomatic Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
dzervas
force-pushed
the
sketch-features-rework
branch
from
39ea948 to
5e61e58
Compare
|
Fantastic work. The tests pass locally and I think this is a big improvement that will make it a lot easier for others to jump in. |
|
the CI build failure is unrelated to the content of this PR so I'm going to just merge this and fix that failure separately |
No description provided.