Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bug fixes & improvements #280

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

BornToBeRoot
Copy link

@BornToBeRoot BornToBeRoot commented Apr 6, 2024

Some improvements & bug fixes

  1. Migration to .NET 8
  2. Fix Right click and drag will "lock" tab item. #132 - Tabs locked in some cases (this requires a .NET version that supports async)
  3. Feature - Use DependencyObject to bind Parition to reuse for e.g. a dragged out window (works if you set it in the constructor)
 <dragablz:InterTabController InterTabClient="{Binding InterTabClient}" Partition="{Binding InterTabPartition }" />
  1. Fix - TabEmptiedResponse.DoNothing leaves empty grids when the last tab is closed. To remove them without closing the window, I added TabEmptiedResponse.CloseLayoutBranch.
public TabEmptiedResponse TabEmptiedHandler(TabablzControl tabControl, Window window)
{
    return window is MainWindow ? TabEmptiedResponse.CloseLayoutBranch : TabEmptiedResponse.CloseWindowOrLayoutBranch;
}
  1. Feature - Disable branch consolidation for a TabablzControl via DependencyProperty (e.g. if you have a "main" TabablzControl that is responsible for creating new tab items and you don't want this to get destroyed on the last tab that is dragged out)
<dragablz:TabablzControl ClosingItemCallback="{Binding CloseItemCommand}"
                                 ItemsSource="{Binding TabItems}" 
                                 SelectedIndex="{Binding SelectedTabIndex}"
                                 DisableBranchConsolidation="True">
...
</dragablz:TabablzControl
  1. Upate MahApps resource keys for brushes/colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right click and drag will "lock" tab item.
1 participant