nflgame.teams cleanup; too many commas ValueError; reduce() TypeError
#328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th no initial value
|
Many Bothans died for that Charles Leno, Jr fix. |
|
@ochawkeye Hey, this code seems like it really should be merged. Since this PR won't be accepted here, would you mind if it got merged into derek-adair's fork instead? Either if you submit a PR or if I did. |
derek-adair
pushed a commit
to derek-adair/nflgame
that referenced
this pull request
Aug 23, 2018
* 22nd Annual Charles Leno Junior Memorial Award(TM) * Cleanup nfl team list in __init__.py Removed arbitary teams that included a dot between letters as alternate name. Reordered SD and LAC teams so non-existant SD team quit overwriting LAC. * Fix TypeError when reduce() is performed on an empty list * _create_schedule demonstration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDaboveLACavoids overwriting Charger players with team ofSD.nflgame.standard_team(TEAM).TypeErrorwhen collecting players over an empty list of games.