Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to work in TwinCAT version 4026 with 99% functionality #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

djonas171
Copy link

@djonas171 djonas171 commented Jan 9, 2025

TcMatrix for TwinCAT 4026 have disabled Method: GetSubMatrixAccessor and FillFromAt due to compiler issues. Otherwise this verision should have full functionallity.

The method calls:
GetShrunkMatrixAccessor
GetTransposeMatrixAccessor
Have been changed so they no longer creates a compiler error. This sadly means the call have to be made a little different, but is it very easy to adjust to.

Old call example: Mt := M1.GetTransposeMatrixAccessor();
New call example: M1.GetTransposeMatrixAccessor(Mt);

The solution have been opened in 4026 so it is no longer compatible with solutions running 4024 or lower.
The update passes all Unit tests as no test is using the method FillFromAt.

JSL - VM and others added 2 commits January 9, 2025 13:26
TcMatrix for TwinCAT 4026 have disabled Method: GetSubMatrixAccessor and FillFromAt.
@BurksEngineering
Copy link
Owner

Thank you for contributing the solution!
I think the matrix accessor and FillFromAt stuff is used some in the TcTransform and TcGeo libraries that depend on this library, but I'm not sure. Obviously, I should have put a unit test in TcMatrix to lock down the behavior, especially if another library depended on it.

I'm not a git workflow expert, but if it isn't too hard I would prefer for you to start a 4026 branch for TcMatrix and put these changes in there so that we don't lose 4024 functionality. Let me know if there is anything I can do to make that branch easier for you to contribute to!

@djonas171
Copy link
Author

I think it is a good idea with a seperate branch, i do not have much time this week to make it, but i will try, otherwise i will do it next week. Thanks for reaching out! it is very nice that we can create a solution and keep using your brillant library!

@djonas171
Copy link
Author

I have just received news from Beckhoff that the "NullReference error" is not reproducible in version their internal version 4026.14 which is expected to be released in the coming weeks, - maybe 2-4 weeks from now.
This could mean that compiler issue have been solved, an no code change is needed, but it is not a guarantee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants