Feature mcvd (#21)

.travis.yml

@@ -1,5 +1,8 @@
 language: php
-sudo: required
+dist: xenial
+
+services:
+  - mysql
 
 cache:
   apt: true
@@ -10,7 +13,6 @@ cache:
 
 php:
   - 7.2
-  - 5.6
 
 branches:
   only:

config/install/ivw_integration.settings.yml

@@ -25,3 +25,4 @@ frabo_default: 'in'
 frabo_overridable: false
 frabo_mobile_default: 'mo'
 frabo_mobile_overridable: false
+mcvd: false

config/schema/ivw_integration.schema.yml

@@ -83,3 +83,6 @@ ivw_integration.settings:
     frabo_mobile_overridable:
       type: boolean
       label: 'Frabo control for mobile is overridable'
+    mcvd:
+      type: boolean
+      label: 'Activate Multistage Client & Visit Detection (MCVD)'

ivw_integration.module

@@ -19,6 +19,7 @@ function ivw_integration_theme() {
         'cp' => NULL,
         'sv' => NULL,
         'co' => NULL,
+        'sc' => NULL,
         'mobile_st' => NULL,
         'mobile_cp' => NULL,
         'mobile_sv' => NULL,

src/Form/SettingsForm.php

@@ -127,7 +127,12 @@ public function buildForm(array $form, FormStateInterface $form_state) {
       '#default_value' => $ivw_integration_settings->get('mobile_width'),
       '#description' => $this->t('On a responsive site, this value tells the javascript up to which screen width, the device should be treated as mobile.'),
     ];
-
+    $form['site_settings']['mcvd'] = [
+      '#type' => 'checkbox',
+      '#title' => $this->t('Activate Multistage Client & Visit Detection (MCVD)'),
+      '#default_value' => $ivw_integration_settings->get('mcvd'),
+      '#description' => $this->t('This activates the MCVD tracking capability. See <a href="https://www.infonline.de/downloads/web-mew-und-ctv/">INFOnline Fact Sheet \'Multistage Client & Visit Detection\' (MCVD)</a> for more information about this.'),
+    ];
     $frabo_default = $ivw_integration_settings->get('frabo_default');
     $form['default_values']['frabo_default'] = [
       '#type' => 'select',
@@ -398,6 +403,7 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
       ->set('frabo_overridable', $values['frabo_overridable'])
       ->set('frabo_mobile_default', $values['frabo_mobile_default'])
       ->set('frabo_mobile_overridable', $values['frabo_mobile_overridable'])
+      ->set('mcvd', $values['mcvd'])
       ->save();
   }
 

src/IvwTracker.php

@@ -73,6 +73,7 @@ public function getTrackingInformation() {
         'cp' => $this->getCp(),
         'sv' => $this->getSv(),
         'mobile_sv' => $this->getMobileSv(),
+        'sc' => $this->getSc(),
       ];
       // Calculate cpm based upon cp.
       // TODO: this is absolutely not generic.
@@ -140,6 +141,16 @@ protected function getMobileSv() {
     return empty($sv) ? 'mo' : $sv;
   }
 
+  /**
+   * Gets the sc parameter.
+   *
+   * @return string
+   *   The value of the st parameter.
+   */
+  protected function getSc() {
+    return $this->configFactory->get('ivw_integration.settings')->get('mcvd') ? 'yes' : '';
+  }
+
   /**
    * {@inheritdoc}
    */

src/Plugin/Block/IvwCallBlock.php

@@ -100,6 +100,7 @@ public function build() {
         '#st' => $tracker['st'],
         '#cp' => $tracker['cp'],
         '#sv' => $tracker['sv'],
+        '#sc' => $tracker['sc'],
     // Not yet configurable.
         '#co' => '',
         '#mobile_cp' => $tracker['cpm'],

templates/ivw-call.html.twig

@@ -3,7 +3,8 @@
         "st": "{{ st }}",
         "cp": "{{ cp }}",
         "sv": "{{ sv }}",
-        "co": "{{ co }}"
+        "co": "{{ co }}",
+        "sc": "{{ sc }}"
     };
 
     if ( (window.innerWidth < {{ mobile_width }}) || (/iPhone/.test(window.navigator.userAgent))) {

tests/src/Unit/IvwLookupServiceTest.php

@@ -92,6 +92,7 @@ protected function setUpConfigFactoryMock() {
     $config->set('paid_overridable', 0);
     $config->set('content_default', '01');
     $config->set('content_overridable', 1);
+    $config->set('mcvd', 0);
 
     $this->configFactoryMock->expects($this->once())
       ->method('get')