feat: change serve function

BunnyWay · Aug 29, 2024 · 49b0fa1 · 49b0fa1
1 parent 0625f1a
commit 49b0fa1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/polite-trees-grab.md b/.changeset/polite-trees-grab.md
@@ -0,0 +1,5 @@
+---
+"@bunny.net/edgescript-sdk": minor
+---
+
+serve function should have the handler as first arg
diff --git a/example/deno-simple-http-page/src/main.ts b/example/deno-simple-http-page/src/main.ts
@@ -5,7 +5,7 @@ function sleep(ms: number): Promise<void> {
 }
 
 console.log("Starting server...");
-BunnySDK.net.http.serve({ port: 8080, hostname: '127.0.0.1' }, async (req) => {
+BunnySDK.net.http.serve(async (req) => {
   console.log(`[INFO]: ${req.method} - ${req.url}`);
   await sleep(1);
   return new Response("blbl");

diff --git a/example/simple-http-page/src/main.ts b/example/simple-http-page/src/main.ts
@@ -6,7 +6,7 @@ function sleep(ms: number): Promise<void> {
 
 console.log("Starting server...");
 
-BunnySDK.net.http.serve({ port: 8080, hostname: '127.0.0.1' }, async (req) => {
+BunnySDK.net.http.serve(async (req) => {
   console.log(`[INFO]: ${req.method} - ${req.url}`);
   await sleep(1);
   return new Response("blbl");

diff --git a/libs/bunny-sdk/src/net/serve.ts b/libs/bunny-sdk/src/net/serve.ts
@@ -16,9 +16,9 @@ type ServeHandler = {} & unknown;
 /**
  * Serves HTTP requests on the given [TcpListener]
  */
-function serve(listener: { port: number; hostname: string; }, handler: ServerHandler): ServeHandler;
-function serve(listener: TcpListener, handler: ServerHandler): ServeHandler;
-function serve(listener: TcpListener | { port: number; hostname: string; }, handler: ServerHandler): ServeHandler {
+function serve(handler: ServerHandler, listener: { port: number; hostname: string; }): ServeHandler;
+function serve(handler: ServerHandler, listener: TcpListener): ServeHandler;
+function serve(handler: ServerHandler, listener?: TcpListener | { port: number; hostname: string; },): ServeHandler {
   const platform = internal_getPlatform();
 
   const listenerUnion = Tcp.isTcpListener(listener) ? listener : Tcp.unstable_new();