Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for RC9 contracts #41

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Updates for RC9 contracts #41

merged 17 commits into from
Jan 9, 2024

Conversation

EdNoepel
Copy link
Collaborator

@EdNoepel EdNoepel commented Dec 30, 2023 •
edited
Loading

Changes

  • Updated ABIs and typechain artifacts
  • Switch to RC9 testchain
  • Renamed deposit fee (isn't just for unutilized deposits anymore)
  • Removed obsolete parameters from add/move/remove quote token operations
  • Updated unit tests
  • Started work on facility to dump error hashes (used to debug testchain deployment)

@EdNoepel EdNoepel requested a review from imbaniac December 30, 2023 17:08
imbaniac
imbaniac reviewed Jan 2, 2024
View reviewed changes
src/classes/Pool.ts Outdated Show resolved Hide resolved
imbaniac
imbaniac approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@imbaniac imbaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did shallow test of dapp, looks fine

@imbaniac imbaniac merged commit 46f2c65 into develop Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Majorfi Majorfi Majorfi approved these changes

@imbaniac imbaniac imbaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdNoepel @imbaniac @Majorfi