Correctly handle arrow function expression arguments when used with non-'on' properties #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-'on' properties
🦋 Changeset detectedLatest commit: a26ce0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit a26ce0a.
☁️ Nx Cloud last updated this comment at |
Deploying mitosis with
|
| Latest commit: |
a26ce0a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49c19f1c.mitosis-9uh.pages.dev |
| Branch Preview URL: | https://allow-arrow-function-express.mitosis-9uh.pages.dev |
samijaber
reviewed
Jan 30, 2025
| '@builder.io/mitosis': patch | ||
| --- | ||
|
|
||
| Fix arrow function expressions in non-on properties |
There was a problem hiding this comment.
on how to format the changesets https://github.com/BuilderIO/mitosis/blob/main/CONTRIBUTING.md#changeset-format
kylefowler
reviewed
Jan 31, 2025
| @@ -282,11 +282,9 @@ export const jsxElementToJson = ( | |||
| if (types.isStringLiteral(expression)) { | |||
| // <Foo myProp={"hello"} /> | |||
| memo.properties[key] = expression.value; | |||
| } else if (types.isArrowFunctionExpression(expression)) { | |||
| } else if (key.startsWith('on') && types.isArrowFunctionExpression(expression)) { | |||
There was a problem hiding this comment.
so the fix for non-on properties is to not have them run this code for isArrowFunctionExpression?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle arrow function expressions for non-on properties. See https://mitosis.builder.io/playground/?code=KYDwDg9gTgLgBAE2AMwIYFcA29noHYDGMAlhHnALICeAwhALaR7B4wAUAlHAN4BQvcOFGAx0UcmwGDpAHmJ4w6GFOlwYwAM4wAvNzaoANHABGRgl20A%2BOKjgBqE%2FbgEAviukB6S1I4BuXi5AA%3D%3D%3D for an example of how it is currently broken.
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.