Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attribute-passing for angular and stencil enabled in options #1668

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

nmerget
Copy link
Contributor

@nmerget nmerget commented Jan 23, 2025

Description

Please provide the following information:

Fixed options for #1665

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@nmerget nmerget requested a review from samijaber as a code owner January 23, 2025 08:03
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 33c08a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Jan 23, 2025

View your CI Pipeline Execution ↗ for commit 33c08a7.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 7s View ↗
nx run-many --target test ✅ Succeeded 4m 33s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 41s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 07:26:49 UTC

@nmerget nmerget marked this pull request as draft January 23, 2025 09:13
@nmerget nmerget marked this pull request as ready for review January 24, 2025 14:50
@nmerget nmerget marked this pull request as draft January 27, 2025 07:30
@nmerget nmerget marked this pull request as ready for review January 27, 2025 08:42
@nmerget nmerget requested a review from samijaber January 28, 2025 07:20
@samijaber samijaber merged commit d24889d into BuilderIO:main Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants