Fix detail page layout (#162)

* fix detail view page layout * fix styling
BuildFire · Mar 10, 2022 · 6594e18 · 6594e18
1 parent 66ad1e6
commit 6594e18
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 29 deletions.
diff --git a/src/widget/css/general.css b/src/widget/css/general.css
@@ -48,6 +48,8 @@
     -webkit-overflow-scrolling: touch;
 }
 
+#carouselView { height: 56.25vw !important; }
+
 #carouselView img {
     width: 100%;
 }
@@ -283,7 +285,6 @@ a[href^="https://maps.google.com/maps"]{display:none !important}
 
 .detail-info {
     width: 65%;
-    padding-left: 3%;
 }
 
 .map-holder {
@@ -330,7 +331,7 @@ a[href^="https://maps.google.com/maps"]{display:none !important}
 
 .map-details .address {
     font-weight: 300;
-    font-size: 11px;
+    font-size: 12px;
     line-height: 1.3;
     color: #121212 !important;
 }
@@ -512,15 +513,13 @@ a[href^="https://maps.google.com/maps"]{display:none !important}
     border: none;
     color: #fff;
     font-size: 15px;
-    border-radius: 100px;
+    border-radius: 4px;
     padding: 10px 0;
     float: left;
     cursor: pointer;
 }
 #bookmarkBtn {
-    font-size: 7vw;
-    margin: auto;
-    left: 2%;
+    font-size: 24px;
 }
 #distance-holder {
     min-width: 14%;
@@ -533,7 +532,7 @@ a[href^="https://maps.google.com/maps"]{display:none !important}
     border: none;
     color: #fff;
     font-size: 15px;
-    border-radius: 100px;
+    border-radius: 4px;
     padding: 10px 0;
     float: left;
     cursor: pointer;
@@ -573,10 +572,12 @@ a[href^="https://maps.google.com/maps"]{display:none !important}
     margin-bottom: 15px;
 }
 
+@media only screen and (min-width : 768px){
+    #bookmarkBtn { font-size: 32px; }
+}
+
 @media only screen and (min-width : 768px) and (max-width : 1024px)
-{ 
-    #bookmarkBtn { font-size: 3.5vw; }
-
+{   
     .col-image { height: 160px; width: 160px }
     .detail-image { width: 140px; height: 140px; }
 
@@ -588,17 +589,12 @@ a[href^="https://maps.google.com/maps"]{display:none !important}
     .slideInDown { height: 155px; }
     .map-holder { height: 400px; }
 
-    #carouselView { height: 400px !important; }
-    #carouselView img { height: 100%; }
-
     .distance-indicator .distance { font-size: 16px; color: black; }
     .distance-indicator .arrow { height: 30px; }
 } 
 
 @media only screen and (min-width: 1024px) and (max-width: 1366px) and (-webkit-min-pixel-ratio: 2) {
 
-    #bookmarkBtn { font-size: 3.5vw; }
-
     .col-image { height: 180px; width: 180px }
     .detail-image { width: 160px; height: 160px; }
 
@@ -609,9 +605,6 @@ a[href^="https://maps.google.com/maps"]{display:none !important}
     .sidenav { height: 30vh; }
     .map-holder { height: 400px; }
 
-    #carouselView { height: 400px !important; }
-    #carouselView img { height: 100%; }
-
     .slideInDown { height: 175px; }
     .loryFrame { height: inherit; }
 

diff --git a/src/widget/js/detail.js b/src/widget/js/detail.js
@@ -229,8 +229,6 @@ window.detailView = {
                  */
                 if (place.carousel && place.carousel.length) {
                     let targetNode = document.getElementById('carouselView');
-                    // Set carousel's height to a 16:9 aspect ratio
-                    targetNode.style.height = `${window.innerWidth / 16 * 9}px`;
                     new components.carousel.view({
                         selector: targetNode,
                         items: place.carousel

diff --git a/src/widget/templates/detail.hbs b/src/widget/templates/detail.hbs
@@ -6,14 +6,14 @@
             <div class="detail-info">
                 <div class="title">{{title}}</div>
                 <div class="address">{{address}}</div>
-            </div>
-            <div id="distance-holder">
-                {{#if distance }}<img class="arrow" src="./images/arrow.png"> <span
-                    class="distance">{{distance}}</span>{{/if}}
+                <div id="distance-holder">
+                    {{#if distance }}<img class="arrow" src="./images/arrow.png"> <span
+                        class="distance">{{distance}}</span>{{/if}}
+                </div>              
             </div>
             {{#if isBookmarkingAllowed}}
             <div id="bookmarkBtn" class="glyphicon glyphicon-star"></div>
-            {{/if}}
+            {{/if}}  
         </div>
     </div>
 </div>
@@ -59,10 +59,10 @@
         <div class="detail-info">
             <div class="title">{{title}}</div>
             <div class="address">{{address}}</div>
-        </div>
-        <div id="distance-holder">
-            {{#if distance }}<img class="arrow" src="./images/arrow.png"> <span
-                class="distance">{{distance}}</span>{{/if}}
+            <div id="distance-holder">
+                {{#if distance }}<img class="arrow" src="./images/arrow.png"> <span
+                    class="distance">{{distance}}</span>{{/if}}
+            </div>
         </div>
         {{#if isBookmarkingAllowed}}
         <div id="bookmarkBtn" class="glyphicon glyphicon-star"></div>