Skip to content

Commit

Permalink
fix: shared object matching bug
Browse files Browse the repository at this point in the history
  • Loading branch information
bobbyg603 committed Apr 16, 2024
1 parent 54f63aa commit 0ffc78c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion spec/sym.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('getSymFileInfo', () => {
});

it('should get module name for file with line feeds', async () => {
const expected = 'libc++_shared';
const expected = 'libc++_shared.so';

const { moduleName } = await getSymFileInfo('./spec/support/android.sym');

Expand Down
2 changes: 1 addition & 1 deletion src/sym.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export async function getSymFileInfo(path: string): Promise<{ dbgId: string, mod
// For now, remove some module name extensions to satisfy the minidump-stackwalker symbol lookup.
function removeIgnoredExtensions(moduleName: string): string {
// We've seen .pdb, .so, .so.0, and .so.6 in the module lookup
const ignoredExtensions = [/\.pdb$/gm, /\.so\.+.*$/gm];
const ignoredExtensions = [/\.pdb$/gm, /\.so\.?.*$/gm];

if (ignoredExtensions.some((regex) => regex.test(moduleName))) {
return moduleName;
Expand Down

0 comments on commit 0ffc78c

Please sign in to comment.