Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to read bval from PVM_DwEffBval and bvec from PVM_DwGradVec #96

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

jeremie-fouquet
Copy link
Contributor

Fixes #90 and #95.

Changes proposed in this pull request:

To consider: according to Bruker documentation for PV6.0.1 and PV360, PVM_DwGradVec is a parameter "specifying the diffusion gradient amplitudes in the x,y,z coordinate system". This coordinate system (the scanner one) does not correspond to the FSL convention, which brkraw seems to be using. I'll open another issue on that topic.

@BrkRaw/Bruker

@dvm-shlee
Copy link
Member

@jeremie-fouquet Do effective bvals and bvacs from this code match the order to the volume generated if the scan is applied repeatedly? If you confirm this, I will apply this change!

@jeremie-fouquet
Copy link
Contributor Author

Hi @dvm-shlee.

For all the data sets I tested, effective bvals from PVM_DwEffBval and bvecs from PVM_DwGradVec were correctly ordered with respect to the acquisition volumes. This is true even for B0 volumes (no need to do additional corrections to the bvals and bvecs for B0 acquisitions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordering of BVAL/BVEC in DTI data
2 participants