Revert to read bval from PVM_DwEffBval and bvec from PVM_DwGradVec #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90 and #95.
Changes proposed in this pull request:
_get_bdata
, revert to reading bval from PVM_DwEffBval and bvec from PVM_DwGradVec. Both of these parameters should include the b0 scans correctly ordered, which solves Ordering of BVAL/BVEC in DTI data #90. PVM_DwEffBval also contains the effective b-values, which include the effect of all applied gradients; it solves Outputted diffusion bval are not the effective b-values anymore #95.To consider: according to Bruker documentation for PV6.0.1 and PV360, PVM_DwGradVec is a parameter "specifying the diffusion gradient amplitudes in the x,y,z coordinate system". This coordinate system (the scanner one) does not correspond to the FSL convention, which brkraw seems to be using. I'll open another issue on that topic.
@BrkRaw/Bruker