Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ClaimSet helper #372

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Remove ClaimSet helper #372

merged 1 commit into from
Nov 29, 2024

Conversation

j3parker
Copy link
Member

This is only used by tests, so I inlined it and removed the class + the overloads to IAccessTokenProvider.

I'm looking to implement an IAM-grant version of that interface and those overloads are annoying. I could have moved these to extension methods probably, but just deleting them seemed better.

@j3parker j3parker marked this pull request as ready for review November 29, 2024 16:51
@j3parker j3parker requested a review from omsmith as a code owner November 29, 2024 16:51
@j3parker j3parker merged commit 04e820f into master Nov 29, 2024
2 checks passed
@j3parker j3parker deleted the remove-claimset branch November 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants