Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #368

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[email protected] #368

merged 1 commit into from
Aug 1, 2024

Conversation

omsmith
Copy link
Contributor

@omsmith omsmith commented Aug 1, 2024

This updates System.IdentityModel.Tokens.Jwt to address GHSA-59j7-ghrg-fj52

@omsmith omsmith requested a review from j3parker as a code owner August 1, 2024 19:03
Comment on lines +17 to +18
<PackageVersion Include="System.IdentityModel.Tokens.Jwt" Version="6.36.0" />
<PackageVersion Include="System.Text.Json" Version="8.0.4" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.IdentityModel.Tokens.Jwt is a legacy library that's been replaced by Microsoft.IdentityModel.JsonWebTokens.

This one still always uses the vendored in-assembly Newtonsoft; however the newer one has switched to using System.Text.Json for net461+, hence the dependency.

@omsmith
Copy link
Contributor Author

omsmith commented Aug 1, 2024

No significant change

BenchmarkDotNet=v0.13.1, OS=Windows 10.0.22621
AMD Ryzen Threadripper PRO 7945WX 12-Cores, 1 CPU, 24 logical and 12 physical cores
  [Host]     : .NET Framework 4.8 (4.8.9256.0), X64 RyuJIT
  DefaultJob : .NET Framework 4.8 (4.8.9256.0), X64 RyuJIT


| Method |        Mean |    Error |   StdDev | Rank |
|------- |------------:|---------:|---------:|-----:|
|  ES256 | 1,205.26 us | 2.117 us | 1.768 us |    4 |
|  ES384 |   554.33 us | 1.998 us | 1.771 us |    3 |
|  ES512 |   251.71 us | 1.428 us | 1.266 us |    2 |
|  RS256 |    53.89 us | 0.263 us | 0.246 us |    1 |
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.22621
AMD Ryzen Threadripper PRO 7945WX 12-Cores, 1 CPU, 24 logical and 12 physical cores
  [Host]     : .NET Framework 4.8 (4.8.9256.0), X64 RyuJIT
  DefaultJob : .NET Framework 4.8 (4.8.9256.0), X64 RyuJIT


| Method |        Mean |    Error |   StdDev | Rank |
|------- |------------:|---------:|---------:|-----:|
|  ES256 | 1,216.47 us | 3.676 us | 3.259 us |    4 |
|  ES384 |   552.58 us | 3.321 us | 2.944 us |    3 |
|  ES512 |   255.73 us | 2.874 us | 2.548 us |    2 |
|  RS256 |    56.07 us | 0.444 us | 0.415 us |    1 |

@omsmith omsmith merged commit 93720e0 into master Aug 1, 2024
2 checks passed
@omsmith omsmith deleted the omsmith/identitymodel-update branch August 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants