update noise tools #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tering and to do digi+reco
…eOffset is now set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use new unified noise tool in both scripts to create map for topoclustering and to do digi+reco in the legacy scripts..
Goes hand in hand with
key4hep/k4FWCore#214
HEP-FCC/k4RecCalorimeter#98
Once fully validated can be ported to FCC-config.
To add noise to the calo cells what remains to be implemented is a port to the ALLEGRO_o1_v03 geometry and readout of https://github.com/HEP-FCC/k4RecCalorimeter/blob/a902075091a928d40c3b6290792d1e2296401190/RecCalorimeter/src/components/TubeLayerPhiEtaCaloTool.h
We should check first whether we can reuse the code in https://github.com/key4hep/k4geo/blob/e5d641abaf68ff0354bcc646842931fd0ee2f79d/detectorCommon/src/DetUtils_k4geo.cpp
Tagging @zwu0922