Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag in FCCSW_ecal/run_thetamodulemerged.py for pi0/photon shape variables #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dasphy
Copy link

@dasphy dasphy commented May 5, 2024

Add flag in FCCSW_ecal/run_thetamodulemerged.py for pi0/photon shape variables.
Related PR: HEP-FCC/k4RecCalorimeter#79

tagging @BrieucF @giovannimarchiori

Cheers, Tong

@giovannimarchiori
Copy link
Contributor

Looks good to me, we can merge so that the code will run in the nightlies, but I would like to encourage everybody to stop using this script and move to https://github.com/HEP-FCC/FCC-config/blob/main/FCCee/FullSim/ALLEGRO/ALLEGRO_o1_v03/run_digi_reco.py

@dasphy
Copy link
Author

dasphy commented Jul 5, 2024

Thanks. Also created another PR in FCC-config :
HEP-FCC/FCC-config#175

Cheers, Tong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants