Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vrf classes #344

Closed
wants to merge 3 commits into from
Closed

update vrf classes #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17e8676
update vrf classes
jli113 Oct 23, 2021
de91d5d
Merge branch 'BrickSchema:master' into master
jli113 Nov 24, 2021
253cd3f
update packaged air conditioners
jli113 Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 69 additions & 4 deletions bricksrc/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,71 @@
},
},
"Steam_System": {"tags": [TAG.Steam, TAG.System]},
"Refrigerant_System": {
"tags": [TAG.Fluorocarbon_Refrigerant, TAG.Hydrocarbon_Refrigerant, TAG.System],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the tags should be just "Refrigerant" instead of the types of refrigerant. The tags are "necessary" conditions but in my understanding those refrigerant are may or may not be used together.

"subclasses": {
"Single_Split_System": {
"tags": [
TAG.Fluorocarbon_Refrigerant,
TAG.Hydrocarbon_Refrigerant,
TAG.Heat,
TAG.Cool,
TAG.System,
TAG.Indoor_Unit,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Units do not have to be part of the system's tags, especially given that the tags are "necessary" conditions for the class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Units may be a part of the system, but it doesn't mean that it has to be the tags for the system class.

TAG.Outdoor_Unit
],
},
"Multi_Split_System": {
"tags": [
TAG.Fluorocarbon_Refrigerant,
TAG.Hydrocarbon_Refrigerant,
TAG.Heat,
TAG.Cool,
TAG.System,
TAG.Indoor_Unit,
TAG.Outdoor_Unit,
TAG.Mode_Switch_Box
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to units in the previous comment. Mode_Switch_Box may be isPartOf a system but it shouldn't be a tag of the system.

],
},
"VRF_System": {
"tags": [
TAG.Fluorocarbon_Refrigerant,
TAG.Hydrocarbon_Refrigerant,
TAG.Heat,
TAG.Cool,
TAG.System,
TAG.Indoor_Unit,
TAG.Outdoor_Unit,
TAG.Mode_Switch_Box],
"subclasses":{
"VRF_Heat_Pump_System": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is Equipment instead of System. Would you agree with it?

"tags": [
TAG.Fluorocarbon_Refrigerant,
TAG.Hydrocarbon_Refrigerant,
TAG.Heat,
TAG.Cool,
TAG.System,
TAG.Indoor_Unit,
TAG.Outdoor_Unit,
TAG.Mode_Switch_Box
],
},
"VRF_Heat_Recovery_System": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this, would it be a piece of Equipment instead of a System?
For system vs equipment, check
https://brickschema.org/ontology/1.2/classes/System/
https://brickschema.org/ontology/1.2/classes/Equipment/

"tags": [
TAG.Fluorocarbon_Refrigerant,
TAG.Hydrocarbon_Refrigerant,
TAG.Heat,
TAG.Cool,
TAG.System,
TAG.Indoor_Unit,
TAG.Outdoor_Unit,
TAG.Mode_Switch_Box
],
},
},
},
},
},
"Water_System": {
"tags": [TAG.Water, TAG.System],
"subclasses": {
Expand All @@ -63,7 +128,7 @@
"tags": [
TAG.Hot,
TAG.Water,
TAG.System,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty space

TAG.Preheat,
TAG.System,
]
Expand All @@ -72,7 +137,7 @@
"tags": [
TAG.Hot,
TAG.Water,
TAG.System,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty space

TAG.Reheat,
TAG.System,
]
Expand All @@ -81,7 +146,7 @@
"tags": [
TAG.Hot,
TAG.Water,
TAG.System,
TAG.Radiation,
TAG.System,
]
Expand All @@ -90,7 +155,7 @@
"tags": [
TAG.Hot,
TAG.Water,
TAG.System,
TAG.Heat,
TAG.Recovery,
TAG.System,
Expand Down
Loading