Graceful shutdown #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integer instead of ClientTimeout Bot-detector#42
extreme4all
reviewed
Dec 3, 2023
Comment on lines
+158
to
+168
| # logger.info(f"Scraped data for player: {player.name}") | ||
| scrape_counter += 1 | ||
| logger.debug(f"scrape_counter: {scrape_counter}") # Add this line | ||
| if scrape_counter == 100: | ||
| logger.debug("scrape_counter reached 100") # Add this line | ||
| end_time = time.time() | ||
| logger.info( | ||
| f"Scraped 100 players in {end_time - start_time} seconds" | ||
| ) | ||
| start_time = time.time() | ||
| scrape_counter = 0 |
There was a problem hiding this comment.
you really don't want this, every proxy will run this at the same time (#250 proxies), the desired speed should be about 500.000 scrapes an hour, in the past we've seen significant slowdoing logging this every line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for missing data issue #44