feat: add Bencher::iter_with_setup_wrapper
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overlookmotel
force-pushed
the
iter-with-setup-wrapper
branch
from
ddd80e3 to
343a49d
Compare
Boshen
force-pushed
the
iter-with-setup-wrapper
branch
from
343a49d to
0184f71
Compare
Merged
Boshen
added a commit
that referenced
this pull request
Aug 27, 2024
## 🤖 New release * `criterion2`: 1.0.0 -> 1.1.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [1.1.0](v1.0.0...v1.1.0) - 2024-08-27 ### Added - add `Bencher::iter_with_setup_wrapper` ([#49](#49)) ### Fixed - fix integration tests not being run </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Boshen
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Aug 27, 2024
Transformer benchmark measure only the transformer itself. Parse, generate `Semantic`, and drop `Semantic` outside of the measured section. This should: 1. Give us greater visibility of how changes to transformer affect its performance. 2. Reduce variance in transformer benchmarks, since they will no longer include the variance introduced by `SemanticBuilder`. Not ready to merge yet. We should first add an "end to end" benchmark testing the entire compilation process (parse - semantic - transform - minify - codegen). This PR depends on Boshen/criterion2.rs#49. This PR currently makes Oxc's dependency on `criterion2` a git dependency on that PR's branch. That can be changed once the upstream PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Bencher::iter_with_setup_wrapper. This API allows setup to be performed before each iteration of the benchmark, and the setup and routine functions can mutably borrow values from outside their closures.This enables us to benchmark Oxc's components in isolation e.g. oxc-project/oxc#5193.