Update packages/core/src/context/experiment/experiment-reducers.ts

Refactor suggestion count logic Co-authored-by: Jakob Langdal <[email protected]>
BoostV · Nov 9, 2023 · 367b4d1 · 367b4d1
1 parent 724c9a8
commit 367b4d1
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/packages/core/src/context/experiment/experiment-reducers.ts b/packages/core/src/context/experiment/experiment-reducers.ts
@@ -187,13 +187,12 @@ export const experimentReducer = produce(
         break
       case 'updateSuggestionCount': {
         const payloadVal = Number(action.payload.suggestionCount)
-        const maxSuggestionCount = action.payload.maxSuggestionCount
-        let actualVal = payloadVal
-        if (maxSuggestionCount !== undefined) {
-          actualVal =
-            payloadVal <= maxSuggestionCount ? payloadVal : maxSuggestionCount
-        }
-        state.extras.experimentSuggestionCount = actualVal >= 1 ? actualVal : 1
+        const maxSuggestionCount =
+          action.payload.maxSuggestionCount ?? Number.MAX_VALUE
+        state.extras.experimentSuggestionCount = Math.max(
+          1,
+          Math.min(maxSuggestionCount, payloadVal)
+        )
         break
       }
       case 'copySuggestedToDataPoints': {