Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return interactive pareto plot via bokeh-json #50

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

abbl-DTI
Copy link
Member

Update to the return for process_result when optimizer.n_objectives > 1.
This update is dependent on ProcessOptimizer = 7.5
This PR closes #48

@abbl-DTI abbl-DTI requested a review from langdal October 31, 2022 08:50
@abbl-DTI abbl-DTI linked an issue Oct 31, 2022 that may be closed by this pull request
@langdal
Copy link
Member

langdal commented Nov 3, 2022

It should be possible to use fixed dependencies of ProcessOptimizer by installing using pip install ProcessOptimizer[browniebee] as described in novonordisk-research/ProcessOptimizer#108

Use the Brownie Bee specific package of ProcessOptimizer.
Update frozen requirements according to README
@langdal
Copy link
Member

langdal commented Nov 4, 2022

@abbl-DTI Tests fail in this branch because a sub-module in ProcessOptimizer is missing from the distribution package. It looks like the module "model_systems" is not included in the distribution. Looking at the ProcessOptimizer repo it looks like that module has been added recently and might need to be added to the build script (setup.py)?

@langdal
Copy link
Member

langdal commented Nov 4, 2022

@abbl-DTI I just noticed that you already created an issue in PO for this :)
novonordisk-research/ProcessOptimizer#124

btw. I have added a commit that use the fixed deps. version of PO

@langdal langdal mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Pareto plot as Bokeh JSON
2 participants