Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_json_map.py and default_map.json #6

Closed
wants to merge 4 commits into from

Conversation

ll7
Copy link
Contributor

@ll7 ll7 commented Jan 4, 2024

No description provided.

@Bonifatius94
Copy link
Owner

implement an officially supported map file format instead of this example

@ll7
Copy link
Contributor Author

ll7 commented Jan 5, 2024

So we should research typical map file formats?

@Bonifatius94
Copy link
Owner

Your format is fine, but I'd like to move the parser function to map_config.py.

We should also consider to change the map_definition parameter of Simulator_v2 to either MapDefinition or string such that the simulator can figure out the parsing internally.

@ll7
Copy link
Contributor Author

ll7 commented Jan 5, 2024

We could consider handling maps as svg files, which would reduce the importance of a map editor. Drawing svg maps, obstacles and routes could be easier and different classes are identified by color coding?

https://www.w3.org/wiki/SVG_Map could be helpful, but SVG itself is just a standardized XML file, which you dislike?

@Bonifatius94
Copy link
Owner

SVG Map is a very bloated format. It's very hard to parse and manually edit. The only advantage would be that OpenStreetMap uses this format, so you can get access to real map data. But even then, proportions are not 1:1.

@Bonifatius94
Copy link
Owner

I've added your default map and map parser logic into the project and pushed it to main. We can think about official map formats at a later stage of this project. For now, I'll close your PR. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants