Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.9.3 #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −8
Open

Release 0.9.3 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R-package/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: agtboost
Type: Package
Title: Adaptive and Automatic Gradient Boosting Computations
Version: 0.9.2
Date: 2021-11-09
Version: 0.9.3
Date: 2021-11-23
Author: Berent Ånund Strømnes Lunde
Maintainer: Berent Ånund Strømnes Lunde <[email protected]>
Description: Fast and automatic gradient tree boosting designed
Expand Down
35 changes: 35 additions & 0 deletions R-package/cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,40 @@ agtboost 0.9.2 (2021-11-09)
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Berent Ånund Strømnes Lunde <[email protected]>'

## rhub::check_for_cran check results

on Fedora Linux, R-devel, clang, gfortran
0 errors | 0 warnings | 1 notes

* checking installed package size ... NOTE
installed size is 8.0Mb
sub-directories of 1Mb or more:
libs 7.4Mb

This is due to not re-including debugging information in Makevars, as specified by the CRAN policy and pointed out by Prof Brian Ripley. A shared-object (.so) is larger than perhaps necessary, but compliant with CRAN policies.

## Changes in agtboost 0.9.3
Following e-mail from Prof Brian Ripley:
"The CRAN policy contains
- Packages should not attempt to disable compiler diagnostics, nor to
remove other diagnostic information such as symbols in shared objects."
Thus, agtboost 0.9.3 re-includes debugging information. This leads to package being larger on some OS.

------------------------------------------------------------------------
agtboost 0.9.2 (2021-11-09)
------------------------------------------------------------------------
## Test environments
* local darwin17 install, R 4.1.1
* winbuilder
* devtools check
* rhub check_for_cran, check_on_solaris, check_with_sanitizers

## R CMD check results

0 errors | 0 warnings | 1 notes

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Berent Ånund Strømnes Lunde <[email protected]>'

## Changes in agtboost 0.9.2
Some patching of serialization/deserialization of model objects, along with new features for model training. A deprecation notice is included, and package should be smaller on some OS due to stripping debugging information.
6 changes: 0 additions & 6 deletions R-package/src/Makevars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,3 @@ CXX_STD = CXX11

PKG_CPPFLAGS = -I../inst/include
#PKG_CXXFLAGS = -std=c++11

## decrease size of libs/.so objects after build
strippedLib: $(SHLIB)
if test -e "/usr/bin/strip" & test -e "/bin/uname" & [[ `uname` == "Linux" ]] ; then /usr/bin/strip --strip-debug $(SHLIB); fi

.phony: strippedLib