-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow one encryption counter reset per 100 messages to allow changing… #117
Conversation
… batteries and brownouts in devices
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 83.84% 83.11% -0.74%
==========================================
Files 6 6
Lines 520 533 +13
Branches 79 82 +3
==========================================
+ Hits 436 443 +7
- Misses 68 73 +5
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some linting issues (see the first CI / lint test). You should also add tests to see if this works as expected.
And some testing on your own system would be helpful to verify that we don't break stuff for other users.
I believe version in #119 came out a lot nicer than this approach. |
… batteries and brownouts in devices
Attempt to fix #116. Thanks ChatGPT for help. Did not try running this, please review if this makes sense.