Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change metadata to ignore barrel cortex in layer placement hints #13

Closed
wants to merge 1 commit into from

Conversation

alTeska
Copy link
Member

@alTeska alTeska commented Oct 3, 2023

Accompanying the atlas-commons pull request:
BlueBrain/atlas-commons#5

Aiming to solve the barrel columns issue:

#12

@lecriste
Copy link

lecriste commented Oct 3, 2023

I would assign the ignore"["name"] and ignore["query"] values by reading the source feathers (as in here), rather than hardcoding them.

@arnaudon
Copy link
Contributor

arnaudon commented Oct 4, 2023

It is really not possible to have this ignore within the main regex? I'm not so versed in regex to know that, but I guess regex should be powerful enough for us to only change it, and not modify the code?

@alTeska
Copy link
Member Author

alTeska commented Oct 4, 2023

@arnaudon: I tried and I used a little regex to find all of the barrel columns: "SSp-bfd-[^-]*$"

but I am unsure how to do this within one regex, please by all means if anyone does let me know :)

@lecriste: I disagree with loading the file, right now the regex provided inside the metadata is used for finding the children of the SSp-bfd. So this should work when there are no barrels or when we change the barrels' names as well.

@arnaudon
Copy link
Contributor

arnaudon commented Oct 4, 2023

Just playing with https://regexr.com/ I got for layer1:

Screenshot 2023-10-04 at 11 16 51

something like that should work, no?

@lecriste
Copy link

lecriste commented Oct 4, 2023

@lecriste: I disagree with loading the file, right now the regex provided inside the metadata is used for finding the children of the SSp-bfd. So this should work when there are no barrels or when we change the barrels' names as well.

Yes but the string "SSp-bfd" in "name" and in "query" is already contained in the feathers file, right?
So instead of repeating it here, we can just read it from the file so if tomorrow we change region in the file, we don't need to change this code.

@mgeplf
Copy link
Collaborator

mgeplf commented Nov 22, 2023

Since BlueBrain/atlas-commons#5 was closed, I will close this too.

@mgeplf mgeplf closed this Nov 22, 2023
@mgeplf mgeplf deleted the ignore-layer-volume branch November 22, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants