-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow skipping normalization when compute_cell_density
#70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lecriste and @Sebastien-PILUSO can you try this, and see if it solves the problem you were running into? |
I have a counter proposal for this pull request. The issue happened because the outside of the Nissl used is set to 0. Why not solving the issue in the function normalize_intensity in utils.py? |
@drodarie why would you like to still apply the |
Then the function will not do anything and that's fine. This way, we don't have an extra user option which would make the pipeline even more difficult to use. |
See my proposal here |
If that's what you want, that works for me. I very much prefer fewer options that modify the behavior (ie: I agree with what you on |
Ok let's try |
I ran the code using @drodarie's branch and this gave the same cell density file than on the main branch. So this is okay for me. |
Done better in #74 |
No description provided.