refactor quantile regressor classes #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring to avoid duplicate code at the level of
CBMultiplicativeQuantileRegressor
andCBAdditiveQuantileRegressor
. This design (see below) could be improved though by includingCBMultiplicativeGenericRegressor
andCBAdditiveGenericRegressor
. This is, unfortunately, not possible ATM because the class structure relies on inheritance to implement methods. Using composition instead would likely clean up the design, I will attempt to do this in a follow-up PR.