fix incorrect unmount behaviour with usevalue logic #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I accidentally discovered that
useValue
uses an incorrect logic to replacechildComponents
array, which led to someonUnmount
callbacks being called multiple times (and others potentially never).Another thing here is that we reverse the
onUnmount
calls, this way we unmount children first, and parent after that, which should be more logical. I don't use it anywhere, and in general it is common not to guarantee the execution order for such things, but I think it makes more sense. It might change in the future if I add promises support to components.